Add GitHub Actions. #3244
Merged
Add GitHub Actions. #3244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3244 +/- ##
==========================================
+ Coverage 84.23% 84.41% +0.18%
==========================================
Files 264 264
Lines 16700 16703 +3
Branches 3124 3125 +1
==========================================
+ Hits 14067 14100 +33
+ Misses 1636 1581 -55
- Partials 997 1022 +25
Continue to review full report at Codecov.
|
dracos
force-pushed
the
actions
branch
6 times, most recently
from
9155710
to
bfea469
Compare
We now have Image::Magick, so make sure that is handled better.
struan
approved these changes
Nov 16, 2020
| PERL5LIB: local-coverage/lib/perl5 | ||
| HARNESS_PERL_SWITCHES: "-MDevel::Cover=+ignore,local/lib/perl5,commonlib,perllib/Catalyst/[^A],perllib/Email,Test.pm,^t" | ||
|
|
||
| - name: Run tests (with coverage, part 2) |
There was a problem hiding this comment.
So it finishes quicker overall. It's a bit lopsided as you can see from the runs, but was at least an easy place to split them. Now it's in its own workflow, we could consider splitting further...
Originally done in f7873a9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[skip changelog]
Diff failure is because of the changes added to deal with perlmagick being installed now and it trying to shrink the 1x83 test image which fails. OTOH is now testing e.g. the static_map stitch code which it wasn't on Travis.
Tried using the perl version docker images, but had weird test failures (slim base builds? Couldn't work it out), so instead am using GitHub's default, perlbrew to install a specific version and caching that.