Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix non-JS form when all extra questions answered. #3248

Merged
merged 1 commit into from Nov 20, 2020

Conversation

dracos
Copy link
Member

@dracos dracos commented Nov 19, 2020

The code for deciding whether there were extra questions to answer
would always run, even if all the extra questions had been answered.

@codecov
Copy link

codecov bot commented Nov 19, 2020

Codecov Report

Merging #3248 (96192a0) into master (584760b) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3248      +/-   ##
==========================================
+ Coverage   81.33%   81.35%   +0.02%     
==========================================
  Files         309      309              
  Lines       20634    20636       +2     
  Branches     3126     3126              
==========================================
+ Hits        16782    16789       +7     
+ Misses       2830     2825       -5     
  Partials     1022     1022              
Impacted Files Coverage Δ
perllib/FixMyStreet/App/Controller/Report/New.pm 90.89% <100.00%> (+0.02%) ⬆️
web/cobrands/fixmystreet/fixmystreet.js 70.15% <0.00%> (+0.53%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 584760b...96192a0. Read the comment docs.

The code for deciding whether there were extra questions to answer
would always run, even if all the extra questions had been answered.
@dracos dracos force-pushed the fix-non-js-extra-questions-answered branch from 3d70d31 to 96192a0 Compare November 19, 2020 20:01
Copy link
Member

@chrismytton chrismytton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dracos dracos merged commit 86b0323 into master Nov 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants