Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open311 JSON fixes #3279

Merged
merged 2 commits into from Jan 11, 2021
Merged

Open311 JSON fixes #3279

merged 2 commits into from Jan 11, 2021

Conversation

dracos
Copy link
Member

@dracos dracos commented Jan 8, 2021

Stop the JSON output using arrays where not needed (was fixed for requests back in 2017, looks like, but this was missed), and also include JSON links on the index page.

Fixes https://github.com/mysociety/fixmystreet-commercial/issues/2106

@dracos dracos requested a review from davea January 8, 2021 18:32
@codecov
Copy link

codecov bot commented Jan 8, 2021

Codecov Report

Merging #3279 (cbe743e) into master (ac3d686) will decrease coverage by 0.09%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3279      +/-   ##
==========================================
- Coverage   82.12%   82.03%   -0.10%     
==========================================
  Files         316      316              
  Lines       20971    20971              
  Branches     3163     3163              
==========================================
- Hits        17223    17204      -19     
- Misses       2717     2733      +16     
- Partials     1031     1034       +3     
Impacted Files Coverage Δ
perllib/FixMyStreet/App/Controller/Open311.pm 72.18% <100.00%> (+8.28%) ⬆️
web/cobrands/fixmystreet/offline.js 31.75% <0.00%> (-13.28%) ⬇️
web/cobrands/buckinghamshire/assets.js 91.80% <0.00%> (-1.64%) ⬇️
perllib/Utils.pm 97.97% <0.00%> (-1.02%) ⬇️
perllib/FixMyStreet/App/Controller/Rss.pm 68.37% <0.00%> (-0.94%) ⬇️
web/cobrands/fixmystreet/fixmystreet.js 69.90% <0.00%> (-0.33%) ⬇️
perllib/FixMyStreet/DB/ResultSet/Contact.pm 100.00% <0.00%> (+7.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac3d686...cbe743e. Read the comment docs.

Copy link
Member

@davea davea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@dracos dracos merged commit cbe743e into master Jan 11, 2021
@github-pages github-pages bot temporarily deployed to github-pages January 11, 2021 13:55 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants