Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add reports failed count to sendreports output #3316

Merged
merged 1 commit into from Feb 15, 2021
Merged

Conversation

struan
Copy link
Member

@struan struan commented Feb 15, 2021

Also have a list of ids and order output so it's consistent to make
it a bit easier to scan.

@codecov
Copy link

codecov bot commented Feb 15, 2021

Codecov Report

Merging #3316 (619f1b8) into master (a6032ce) will decrease coverage by 9.15%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3316      +/-   ##
==========================================
- Coverage   82.17%   73.02%   -9.16%     
==========================================
  Files         320      268      -52     
  Lines       21338    17176    -4162     
  Branches     3211     3211              
==========================================
- Hits        17535    12543    -4992     
- Misses       2758     3558     +800     
- Partials     1045     1075      +30     
Impacted Files Coverage Δ
perllib/FixMyStreet/Script/Reports.pm 75.38% <100.00%> (+14.36%) ⬆️
perllib/FixMyStreet/App/Controller/Auth/Profile.pm 15.96% <0.00%> (-82.36%) ⬇️
.../FixMyStreet/App/Controller/Admin/ManifestTheme.pm 18.18% <0.00%> (-81.82%) ⬇️
perllib/FixMyStreet/App/Controller/Noise.pm 9.25% <0.00%> (-79.63%) ⬇️
...ib/FixMyStreet/App/Controller/Admin/DefectTypes.pm 15.09% <0.00%> (-75.48%) ⬇️
perllib/FixMyStreet/App/Form/Noise.pm 14.28% <0.00%> (-71.43%) ⬇️
...llib/FixMyStreet/App/Controller/Open311/Updates.pm 23.68% <0.00%> (-71.06%) ⬇️
perllib/FixMyStreet/App/Controller/JSON.pm 17.64% <0.00%> (-68.63%) ⬇️
...yStreet/App/Controller/Admin/ResponsePriorities.pm 21.73% <0.00%> (-67.40%) ⬇️
perllib/FixMyStreet/App/Controller/Auth/Social.pm 10.88% <0.00%> (-67.36%) ⬇️
... and 126 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6032ce...010f804. Read the comment docs.

Copy link
Member

@dracos dracos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, assuming the test is fixed and passes :)
I've wondered about having a summary at the top by body, e.g. of the $count problems, how many from each body so you can see easily which is having an issue, dunno if that's easy to include in this.

t/sendreport/failures.t Outdated Show resolved Hide resolved
@struan struan requested a review from dracos February 15, 2021 13:59
Copy link
Member

@dracos dracos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ids still defined but no longer used

Also a per body count and id list.
Order output so it's consistent to make it a bit easier to scan.
@struan struan merged commit 010f804 into master Feb 15, 2021
@github-pages github-pages bot temporarily deployed to github-pages February 15, 2021 15:23 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants