Fix double Gaze call #3324
Merged
Fix double Gaze call #3324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3324 +/- ##
=======================================
Coverage 82.19% 82.19%
=======================================
Files 320 320
Lines 21350 21352 +2
Branches 3212 3213 +1
=======================================
+ Hits 17548 17551 +3
+ Misses 2757 2754 -3
- Partials 1045 1047 +2
Continue to review full report at Codecov.
|
For some reason as part of 66f2160, I removed the stashing of the Gaze call (made as part of nearby report looking up) to save it being called again by the map zoom code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And tiny unrelated Hackney thing. But mostly fixing the double Gaze call.
Fixes https://github.com/mysociety/fixmystreet-commercial/issues/2063