Add support for OS Maps API #3328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3328 +/- ##
==========================================
+ Coverage 82.21% 82.27% +0.05%
==========================================
Files 320 324 +4
Lines 21375 21356 -19
Branches 3214 3213 -1
==========================================
- Hits 17574 17571 -3
+ Misses 2753 2742 -11
+ Partials 1048 1043 -5
Continue to review full report at Codecov.
|
davea
approved these changes
Feb 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OS Maps key, layer, URL, and whether it's premium or not can be provided on a per-cobrand basis. In order to do that I had to switch the OSM map classes to use Moo (so e.g. number of zoom levels could look at configuration to work itself out), which hopefully tidies it up a bit at the same time.
The other base change was to store the cobrand being used to set a map class, not just the map class. This is so that, if you are in the scenario where someone is generating a map on a OS-Maps-API-using cobrand, for a report that was generated on a non-OS-Maps-API-using cobrand, it would still be able to access the right information for the API key etc.