Pre-lookup some data for /report/new/ajax call. #3335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3335 +/- ##
==========================================
+ Coverage 82.31% 82.33% +0.02%
==========================================
Files 324 324
Lines 21355 21361 +6
Branches 3213 3214 +1
==========================================
+ Hits 17578 17588 +10
+ Misses 2739 2733 -6
- Partials 1038 1040 +2
Continue to review full report at Codecov.
|
davea
approved these changes
Mar 4, 2021
The call was doing repeated loops of contacts to look up bodies and hint texts, repeated database calls to check anonymous allowed, and making lists of body names it did not need to in templates.
dracos
force-pushed
the
speed-up-report-new-ajax
branch
from
eee5e24
to
2ff0b2d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The call was doing repeated loops of contacts to look up bodies and
hint texts, repeated database calls to check anonymous allowed, and
making lists of body names it did not need to in templates.