Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow email alert radius to be specified. #3350

Merged
merged 1 commit into from
Mar 25, 2021
Merged

Conversation

dracos
Copy link
Member

@dracos dracos commented Mar 22, 2021

Fixes #68 (!)

@codecov
Copy link

codecov bot commented Mar 22, 2021

Codecov Report

Merging #3350 (415aa0d) into master (350efa4) will decrease coverage by 0.01%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3350      +/-   ##
==========================================
- Coverage   82.37%   82.35%   -0.02%     
==========================================
  Files         324      324              
  Lines       21403    21418      +15     
  Branches     3222     3226       +4     
==========================================
+ Hits        17630    17639       +9     
- Misses       2732     2739       +7     
+ Partials     1041     1040       -1     
Impacted Files Coverage Δ
perllib/FixMyStreet/DB/Result/Alert.pm 100.00% <ø> (ø)
web/cobrands/fixmystreet/fixmystreet.js 70.68% <0.00%> (-0.37%) ⬇️
perllib/FixMyStreet/App/Controller/Alert.pm 92.11% <92.30%> (-0.15%) ⬇️
perllib/FixMyStreet/Script/Alerts.pm 90.55% <100.00%> (+0.05%) ⬆️
web/cobrands/fixmystreet-uk-councils/alloy.js 87.12% <0.00%> (-2.98%) ⬇️
web/js/front.js 82.25% <0.00%> (-1.62%) ⬇️
perllib/FixMyStreet/App/Controller/Rss.pm 70.23% <0.00%> (+1.86%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 350efa4...415aa0d. Read the comment docs.

Copy link
Member

@davea davea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As easy as that! Looks good 👍

@dracos dracos merged commit 415aa0d into master Mar 25, 2021
@github-pages github-pages bot temporarily deployed to github-pages March 25, 2021 20:23 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow distance to be set on local email alerts, not just RSS
2 participants