Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Staff access to filter non public places #3616

Merged
merged 2 commits into from Oct 21, 2021

Conversation

dracos
Copy link
Member

@dracos dracos commented Oct 12, 2021

Two related changes - one to let staff search non-public reports in the front page external ID search, and another for staff to see staff categories in the map filters.

@dracos dracos requested a review from davea October 12, 2021 14:55
@codecov
Copy link

codecov bot commented Oct 12, 2021

Codecov Report

Merging #3616 (f3fd987) into master (a6e7516) will decrease coverage by 23.19%.
The diff coverage is 75.00%.

❗ Current head f3fd987 differs from pull request most recent head ed30ed7. Consider uploading reports for the commit ed30ed7 to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##           master    #3616       +/-   ##
===========================================
- Coverage   82.60%   59.40%   -23.20%     
===========================================
  Files         346      282       -64     
  Lines       23585    19164     -4421     
  Branches     3589     3584        -5     
===========================================
- Hits        19483    11385     -8098     
- Misses       2974     6575     +3601     
- Partials     1128     1204       +76     
Impacted Files Coverage Δ
perllib/FixMyStreet/App/Controller/Around.pm 69.41% <66.66%> (-12.97%) ⬇️
perllib/FixMyStreet/App/Controller/Reports.pm 71.46% <100.00%> (-15.71%) ⬇️
perllib/FixMyStreet/App/Form/Wizard.pm 5.88% <0.00%> (-94.12%) ⬇️
perllib/FixMyStreet/App/Form/Waste/Garden.pm 11.11% <0.00%> (-88.89%) ⬇️
perllib/FixMyStreet/DB/Result/AdminLog.pm 8.16% <0.00%> (-85.72%) ⬇️
perllib/FixMyStreet/App/Controller/Noise.pm 8.42% <0.00%> (-84.22%) ⬇️
perllib/FixMyStreet/App/Controller/Auth/Profile.pm 15.96% <0.00%> (-82.36%) ⬇️
perllib/FixMyStreet/App/Controller/Admin/Roles.pm 16.36% <0.00%> (-81.82%) ⬇️
.../FixMyStreet/App/Controller/Admin/ManifestTheme.pm 18.18% <0.00%> (-81.82%) ⬇️
...erllib/FixMyStreet/App/Controller/Questionnaire.pm 11.45% <0.00%> (-80.16%) ⬇️
... and 185 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6e7516...ed30ed7. Read the comment docs.

Copy link
Member

@davea davea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I must have been doing something wrong before because on re-inspection this is in fact working correctly on /reports :) (Tests would be nice though!)

@dracos dracos force-pushed the staff-access-to-filter-non-public-places branch from cc50e9f to ed30ed7 Compare October 21, 2021 15:27
@dracos dracos merged commit ed30ed7 into master Oct 21, 2021
@github-pages github-pages bot temporarily deployed to github-pages October 21, 2021 17:33 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants