Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default make_css to web/cobrands rather than web. #3712

Merged
merged 1 commit into from Dec 14, 2021
Merged

Conversation

dracos
Copy link
Member

@dracos dracos commented Dec 14, 2021

This would fix an issue where if you have, say, a multi-gigabyte photo cache at web/photos, it won't get searched for SCSS files.

@codecov
Copy link

codecov bot commented Dec 14, 2021

Codecov Report

Merging #3712 (79336e2) into master (9810f60) will increase coverage by 2.43%.
The diff coverage is n/a.

❗ Current head 79336e2 differs from pull request most recent head 0ae8d2f. Consider uploading reports for the commit 0ae8d2f to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3712      +/-   ##
==========================================
+ Coverage   82.65%   85.09%   +2.43%     
==========================================
  Files         348      294      -54     
  Lines       23821    19343    -4478     
  Branches     3622     3622              
==========================================
- Hits        19689    16459    -3230     
+ Misses       2991     1744    -1247     
+ Partials     1141     1140       -1     
Impacted Files Coverage Δ
web/cobrands/bathnes/staff.js
web/js/duplicates.js
web/cobrands/buckinghamshire/assets.js
web/cobrands/bromley/a-z-nav.js
web/cobrands/westminster/assets.js
web/cobrands/bromley/assets.js
web/cobrands/fixmystreet/admin.js
web/cobrands/isleofwight/assets.js
web/js/front.js
web/cobrands/fixmystreet.com/front.js
... and 46 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9810f60...0ae8d2f. Read the comment docs.

Copy link
Member

@chrismytton chrismytton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎨

@dracos dracos merged commit d7dbedb into master Dec 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants