Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include username in inactive email. #3734

Merged
merged 1 commit into from Jan 6, 2022
Merged

Conversation

dracos
Copy link
Member

@dracos dracos commented Jan 5, 2022

This has come up in user support (someone had two accounts, one forwarded to the other, they didn't realise) and I see client support (domain name change causing the same issue), so including the email (or phone number) in the body of the inactive email seems like a sensible thing to do at the least.

@dracos dracos requested a review from MorayMySoc January 5, 2022 17:56
@codecov
Copy link

codecov bot commented Jan 5, 2022

Codecov Report

Merging #3734 (a41b5a5) into master (a26b004) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3734      +/-   ##
==========================================
- Coverage   82.53%   82.49%   -0.04%     
==========================================
  Files         350      350              
  Lines       23854    23858       +4     
  Branches     3628     3628              
==========================================
- Hits        19687    19682       -5     
- Misses       3026     3035       +9     
  Partials     1141     1141              
Impacted Files Coverage Δ
web/cobrands/fixmystreet-uk-councils/alloy.js 81.41% <0.00%> (-4.43%) ⬇️
perllib/Open311.pm 92.07% <0.00%> (-1.66%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a26b004...a41b5a5. Read the comment docs.

Copy link
Contributor

@MorayMySoc MorayMySoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to go

@dracos dracos merged commit e64a0a1 into master Jan 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants