Trim whitespace on external status codes for response templates #3997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3997 +/- ##
==========================================
- Coverage 82.54% 73.63% -8.91%
==========================================
Files 362 55 -307
Lines 25025 4752 -20273
Branches 3777 0 -3777
==========================================
- Hits 20656 3499 -17157
+ Misses 3185 1253 -1932
+ Partials 1184 0 -1184 Continue to review full report at Codecov.
|
nephila-nacrea
force-pushed
the
strip-surrounding-whitespace-from-ext-status-code
branch
from
0693a5a
to
8274657
Compare
dracos
reviewed
Jun 28, 2022
dracos
force-pushed
the
strip-surrounding-whitespace-from-ext-status-code
branch
from
ea7a55c
to
ac325aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whitespace was not being trimmed from external status codes, which meant that, if a user accidentally included leading or trailing whitespace, their code would not work in Confirm, etc.
Stemmed from a Bucks ticket (https://mysocietysupport.freshdesk.com/a/tickets/2146) but is a change that applies to all cobrands.
Closes https://github.com/mysociety/societyworks/issues/2818.