Emergency message OOH and on reporting pages #4015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dracos
force-pushed
the
phone-us-messaging-refactoring
branch
from
d8137df
to
07a2475
Compare
Codecov Report
@@ Coverage Diff @@
## master #4015 +/- ##
==========================================
- Coverage 82.84% 82.78% -0.06%
==========================================
Files 362 362
Lines 25290 25267 -23
Branches 3818 3815 -3
==========================================
- Hits 20951 20918 -33
- Misses 3154 3160 +6
- Partials 1185 1189 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
davea
requested changes
Aug 11, 2022
mysociety-pusher
force-pushed
the
phone-us-messaging-refactoring
branch
from
07a2475
to
b6f17b6
Compare
davea
approved these changes
Aug 15, 2022
| @@ -47,6 +47,7 @@ | |||
|
|
|||
| [% IF hardcoded_reporting_message %] | |||
| <p>Your reporting page message is currently hard-coded.</p> | |||
| <pre>[% hardcoded_reporting_message %]</pre> | |||
There was a problem hiding this comment.
I was originally thinking of a rendered preview, but actually showing the HTML makes a lot more sense!
mysociety-pusher
force-pushed
the
phone-us-messaging-refactoring
branch
2 times, most recently
from
93a92b5
to
cb578e8
Compare
mysociety-pusher
force-pushed
the
phone-us-messaging-refactoring
branch
from
cb578e8
to
93a92b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR firstly consolidates a couple of ways of showing a message top left on the reporting pages into using
form_after_heading.html. It then adds the ability to customise that message in the admin, leaving the hard-coded ones alone (though they could be moved to the database way of storing it easily enough). And then it adds OOH handling to all the 'emergency' messages, with an interface for specifying out of hours (defaulting to weekends, BH, midnight-8am/6pm-midnight on weekdays).Don't really like the allowing of
<p class>in the scrubber, but couldn't see an easy way to accommodate both simple text messages like Bucks have with a<strong>and that's about it, or something in a<p class="box-warning">like say National Highways.Would need some documentation on e.g. using that class if that's what we wanted to do. Or set it up for them first time.
Fixes https://github.com/mysociety/societyworks/issues/2570
Note this doesn't apply OOH to extra question stopper messages, I think we'd wait to see if that was wanted then, because that would be another level of complexity, I think, hopefully this could cover most.