For CSV export, fetch children of all generations. #4059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4059 +/- ##
==========================================
- Coverage 82.82% 73.69% -9.13%
==========================================
Files 362 55 -307
Lines 25270 4760 -20510
Branches 3808 0 -3808
==========================================
- Hits 20929 3508 -17421
+ Misses 3154 1252 -1902
+ Partials 1187 0 -1187 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Area IDs are stored on a report at creation; if the areas in MapIt change, due to boundary changes, those IDs no longer match against the data in the current MapIt generation. So fetch all generations of children so old ward information is included.
mysociety-pusher
force-pushed
the
issues/societyworks/3156-old-ward-names-in-export
branch
from
e3f8768
to
edec516
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/mysociety/societyworks/issues/3156
Area IDs are stored on a report at creation; if the areas in MapIt change, due to boundary changes, those IDs no longer match against the data in the current MapIt generation. So fetch all generations of children so old ward information is included.