Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display photo changes in report moderation updates. #4266

Merged
merged 1 commit into from Jan 27, 2023

Conversation

neprune
Copy link
Contributor

@neprune neprune commented Jan 19, 2023

@codecov
Copy link

codecov bot commented Jan 19, 2023

Codecov Report

Merging #4266 (4c45706) into master (c8078c1) will increase coverage by 21.85%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           master    #4266       +/-   ##
===========================================
+ Coverage   60.99%   82.85%   +21.85%     
===========================================
  Files         353      360        +7     
  Lines       26489    27010      +521     
  Branches     4104     4200       +96     
===========================================
+ Hits        16158    22379     +6221     
+ Misses       9070     3378     -5692     
+ Partials     1261     1253        -8     
Impacted Files Coverage Δ
...ib/FixMyStreet/DB/Result/ModerationOriginalData.pm 89.87% <100.00%> (+79.87%) ⬆️
...FixMyStreet/App/Form/Widget/Field/CheckboxGroup.pm 90.00% <0.00%> (ø)
perllib/FixMyStreet/App/Form/Field/MonthDay.pm 100.00% <0.00%> (ø)
perllib/FixMyStreet/App/Form/Field/DOBYear.pm 100.00% <0.00%> (ø)
perllib/Data/ICal/RFC7986.pm 100.00% <0.00%> (ø)
perllib/FixMyStreet/App/Form/Field/Month.pm 100.00% <0.00%> (ø)
perllib/FixMyStreet/App/Form/Field/FileIdUpload.pm 60.00% <0.00%> (ø)
perllib/FixMyStreet/App/Form/Page/Wizard.pm 83.33% <0.00%> (ø)
perllib/FixMyStreet/Geocode/OSM.pm 51.72% <0.00%> (+1.14%) ⬆️
perllib/FixMyStreet.pm 89.06% <0.00%> (+1.56%) ⬆️
... and 148 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@neprune neprune requested a review from dracos January 19, 2023 12:51
Copy link
Member

@dracos dracos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of small things is all :)

perllib/FixMyStreet/DB/Result/ModerationOriginalData.pm Outdated Show resolved Hide resolved
perllib/FixMyStreet/DB/Result/ModerationOriginalData.pm Outdated Show resolved Hide resolved
@neprune neprune requested a review from dracos January 26, 2023 12:09
Copy link
Member

@dracos dracos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :)

@neprune neprune force-pushed the show-unredacted-photos-more-clearly branch from 4c45706 to c3867f4 Compare January 27, 2023 11:47
@neprune neprune merged commit c3867f4 into master Jan 27, 2023
@neprune neprune temporarily deployed to github-pages January 27, 2023 11:48 — with GitHub Pages Inactive
@neprune neprune deleted the show-unredacted-photos-more-clearly branch June 19, 2023 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants