Accessibility related smörgåsbord of things

[dracos]

Fixes https://github.com/mysociety/societyworks/issues/3438
Fixes https://github.com/mysociety/societyworks/issues/3436
Fixes https://github.com/mysociety/societyworks/issues/3433
Fixes https://github.com/mysociety/societyworks/issues/3432 (I think)
Fixes https://github.com/mysociety/societyworks/issues/3430
Fixes https://github.com/mysociety/societyworks/issues/3429

[codecov]

Codecov Report

Merging #4283 (4f1aa33) into master (fb58aa3) will increase coverage by 0.00%.
The diff coverage is 76.92%.

@@           Coverage Diff           @@
##           master    #4283   +/-   ##
=======================================
  Coverage   83.13%   83.13%           
=======================================
  Files         359      359           
  Lines       26627    26625    -2     
  Branches     4128     4128           
=======================================
- Hits        22137    22136    -1     
+ Misses       3244     3243    -1     
  Partials     1246     1246           

Impacted Files	Coverage Δ
web/cobrands/fixmystreet/fixmystreet.js	77.20% <75.00%> (+0.05%)	⬆️
web/js/front.js	83.87% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[lucascumsille]

Hey @dracos Regarding this commit
Add visually-hidden nearest address in report list

It doesn't retrieve the nearest address for me, I also tried using the button "Use my nearest location", but that didn't work either. Do I need to enable something?

[lucascumsille]

[Internal] inner counter

• Fixes https://github.com/mysociety/societyworks/issues/3436
• Fixes https://github.com/mysociety/societyworks/issues/3433
• Fixes https://github.com/mysociety/societyworks/issues/3432 (I think)
• Fixes https://github.com/mysociety/societyworks/issues/3430
• Fixes https://github.com/mysociety/societyworks/issues/3429

Pending commit: 21c6958

[dracos]

Sorry, wasn't clear what that's doing - on an /around or /reports list page, existing reports will have their closest address (if pre-calculated) added to their entry in their list, visually hidden. The pre-calculation only happens when a report is actually sent to a body, which is why you might not have any in your local development.

[lucascumsille]

Sorry, wasn't clear what that's doing - on an /around or /reports list page, existing reports will have their closest address (if pre-calculated) added to their entry in their list, visually hidden. The pre-calculation only happens when a report is actually sent to a body, which is why you might not have any in your local development.

Great thank Matthew, makes sense.

[lucascumsille]

@dracos sorry it's taking me long.
I get why in this commit we got rid of the fieldsets when we didn't have a group. But was a reason to do get rid of it in files like index.html when we could have included a legend?

[dracos]

No worries! A fieldset is to group related controls/labels (e.g. all the radio inputs for a particular question, or if you had a few text inputs all about parts of the user's address, say). I don't think it should be used to group every control within a form, that seems superfluous/confusing. In contact/index.html (and the other cases), I think that's what it's doing. This does make me realise additionally though that contact/who.html is /missing/ a fieldset and should have one there to wrap its radio buttons.

[lucascumsille]

No worries! A fieldset is to group related controls/labels (e.g. all the radio inputs for a particular question, or if you had a few text inputs all about parts of the user's address, say). I don't think it should be used to group every control within a form, that seems superfluous/confusing. In contact/index.html (and the other cases), I think that's what it's doing. This does make me realise additionally though that contact/who.html is /missing/ a fieldset and should have one there to wrap its radio buttons.

That makes sense =). Regarding the contact/who.html, I checked templates/web/fixmystreet.com/contact/who.html, and we don't have a fieldset for that group in the file, but when a inspected https://www.fixmystreet.com//contact, I noticed that we do have a fieldset(wrapping the whole form) with not legend right after the form tag. Not sure where that it's coming from.

[dracos]

"I noticed that we do have a fieldset(wrapping the whole form) with not legend right after the form tag. Not sure where that it's coming from." - that's the one I've removed in this PR in templates/web/base/contact/form.html.

[lucascumsille]

@dracos Looks good. Before I approve, I wanted to check if some these files should also have fieldsets:

• /web/base/dashboard/index.html line 100-105: To wrap the start/ end date?
• templates/web/base/my/my.html line 64-77: Receive update notifications
• templates/web/base/questionnaire/creator_fixed.html line 12-17
• templates/web/base/questionnaire/index.html line 37-44, 63-69, 83-88

[dracos]

Yeah, looks like all of those should have a fieldset.