Skip to content

Commit

Permalink
do not list former positions in header
Browse files Browse the repository at this point in the history
Becuase in the case of people who have held multiple positions in
goverment it's going to be hard to pick the most relevant one so better
not to list them at all. This avoids user confusion about what they
should expect to see as it means it's either:

 * Current seat or position.
 * The last seat they held.

Fixes #1234
Fixes #1081
  • Loading branch information
struan committed Mar 31, 2017
1 parent 1e74fc6 commit 6ae84e1
Showing 1 changed file with 0 additions and 6 deletions.
6 changes: 0 additions & 6 deletions www/docs/mp/index.php
Expand Up @@ -250,12 +250,6 @@
// If this person has named non-committee offices, they override the default
if (count($current_offices) > 0) {
$position = $current_offices[0];
} elseif (count($former_offices) > 0) {
# only use the position if it's current, i.e.
# it does not have an end date
if (!$former_offices[0]->to_date) {
$position = $former_offices[0];
}
}

// Finally, if this is a Votes page, replace the page description with
Expand Down

0 comments on commit 6ae84e1

Please sign in to comment.