Add postcode search to /mp page if redirect fails #865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| default: | ||
| $rep = 'MP'; | ||
| $SEARCHURL = new \URL('mp'); | ||
| $SEARCHURL = $SEARCHURL->generate(); |
There was a problem hiding this comment.
I think this could use /postcode/ in all cases? Might as well stick with the single redirector unless going straight to MP does something different.
There was a problem hiding this comment.
If you use /mp/ it redirects straight to the MP page whereas postcode shows you all the representatives for that postcode so /mp/ saves a click for the user.
|
Looks good. |
struan
force-pushed
the
issues/450-postcode-search-on-mp-page
branch
from
5c9c0f4
to
79ee715
Compare
|
Great! |
If you visit /mp, /msp etc without a postcode set display a postcode search box as well as the link to all MPs Fixes #450
struan
force-pushed
the
issues/450-postcode-search-on-mp-page
branch
from
79ee715
to
75138b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If someone arrives at /mp without either a session with a postcode or a query string then present them with a postcode lookup dialog and also a link to the appropriate list of representatives for the page type.