Display any votes where MP differs from party on profile page #911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
struan
force-pushed
the
issues/910-mp-party-issues-differences
branch
5 times, most recently
from
a609046
to
50cd881
Compare
| $db = new \ParlDB; | ||
|
|
||
| $party_list = $db->query( | ||
| "SELECT DISTINCT party FROM member" |
|
Some questions, but not really on the code which is fine :) |
|
|
| // generate party policy diffs | ||
| $party = new MySociety\TheyWorkForYou\Party($MEMBER->party()); | ||
| $positions = new MySociety\TheyWorkForYou\PolicyPositions( $policiesList, $MEMBER ); | ||
| if ( $party ) { |
|
One tiny query, otherwise 👍 (and yay tests) |
struan
force-pushed
the
issues/910-mp-party-issues-differences
branch
6 times, most recently
from
4625523
to
585b6b5
Compare
Import details of which way an MP has to vote to be in agreement with a policy to allow us to use this in calculations
Run over all policies and use the MPs division votes to calculate the parties position on the policy. Then store that position in a table for later lookup.
If an MP has policies where they are in opposition to their party then display that in the votes box on their profile page. Otherwise default to the existing random selection of votes.
Also ignore Crossbench and Independent parties as they're not really a party so it doesn't make sense to calculate policies positions for them
Avoid confusing people by calculating the policies for Labour and Labour/Co-op MPs as if they were all Labour MPs because that's what people would expect.
in this case it doesn't really make sense to assign a position to the party so the score is -1.
if the party has no positions then we can't say what the policy differences with the MP are so just return an empty set
it was possible if the MP did not have positions on the randomly selected 6 policies that nothing would display in the votes box so if they have party differences display the box.
struan
force-pushed
the
issues/910-mp-party-issues-differences
branch
from
585b6b5
to
16321df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This imports the policy vote from PublicWhip and then uses all the votes of current party members to calculate the party's position on a policy. It then compares that with an MP's position and if it is in opposition then it displays that policy on the MP's profile page.
Connects to #910