Update for 1.4.22 #8
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbp
force-pushed
the
refactor-compiling
branch
from
d3d2416
to
a876dec
Compare
gbp
added a commit
to mysociety/alaveteli
that referenced
this pull request
Mar 13, 2023
|
Rebased to fix failings specs (due to requiring |
gbp
added a commit
to mysociety/alaveteli
that referenced
this pull request
Mar 14, 2023
|
This gem is running on staging.alaveteli.org. All seem to be working. |
sagepe
approved these changes
Mar 27, 2023
There was a problem hiding this comment.
Looks fine to me. From what I can see of the other PRs this is based on, we're not fundamentally changing the approach rather simply using the mini_portile gem to handle compilation rather than manually specifying the commands in the Rakefile. I don't see a problem with this - the end point should be the same.
gbp
added a commit
to mysociety/alaveteli
that referenced
this pull request
Mar 30, 2023
|
Merged in 4a29015 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.