This repository has been archived by the owner on Jan 28, 2020. It is now read-only.
Mayoral Election importer #715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks Mark, I think the fixup commit addresses all your comments. I'll squash it in and give the first commit a better name if you're happy with this. |
|
Looks good 👍 - do go ahead I made this PR with the fixes we discussed for the missing areas issues: #719 - if you could look over that too, that would be great. |
symroe
force-pushed
the
mayoral_importer
branch
from
1a8f659
to
654ec95
Compare
symroe
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is classed at WIP because I expect we'll need to figure out election groupings as part of this PR, or soon after.
Mayors are absolutely different elections, with their own IDs, however it's not very logical to list them differently on the site. It could be that this is a very simple change to
posts.html, or there might be something more complex. #598 talks about this more.For now, I think this script imports the Mayors correctly, with different election IDs, making it technically "done"