Buffer Socket Reads #167

caleblloyd · 2017-01-25T06:28:05Z

Fixes Improve async performance #164
Uses BufferedByteReader to read up to 16384 bytes out of the OS Socket Buffer at once
Changes IByteHandler.ReadAsync method to accept an ArraySegment<byte> buffer parameter that new data is read into

bgrainger · 2017-01-25T06:40:40Z

src/MySqlConnector/Protocol/Serialization/SocketByteHandler.cs

-			{
-				m_socketAwaitable.EventArgs.SetBuffer(payload.Array, payload.Offset, payload.Count);
-			}
+			m_socketAwaitable.EventArgs.SetBuffer(payload.Array, payload.Offset, payload.Count);


The previous code was intentional: d705e20

I wonder if keeping m_buffer in this new code and copying in/out of it would be an improvement or not.

bgrainger · 2017-01-25T06:48:23Z

This PR brings the timings for my test harness to:

.NET Framework sync
real   3.426s
total  1.156s
user   1.156s
sys    0.000s

.NET Framework async
real   3.056s
total  1.438s
user   1.344s
sys    0.094s

.NET Core sync
real   3.564s
total  1.063s
user   1.031s
sys    0.031s

.NET Core async
real   2.769s
total  1.359s
user   1.250s
sys    0.109s

A substantial improvement! 👍

buffer reads. fixes mysql-net#164

e68adf6

bgrainger reviewed Jan 25, 2017

View reviewed changes

bgrainger merged commit 9a4d8d7 into mysql-net:master Jan 25, 2017

bgrainger added a commit that referenced this pull request Jan 25, 2017

Merge pull request #167 from caleblloyd/f_buffer_network.

6294c3f

caleblloyd deleted the f_buffer_network branch February 7, 2017 02:55

caleblloyd mentioned this pull request Apr 21, 2017

Buffered Result Sets over-allocating memory #244

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Buffer Socket Reads #167

Buffer Socket Reads #167

caleblloyd commented Jan 25, 2017

bgrainger Jan 25, 2017

bgrainger commented Jan 25, 2017

Buffer Socket Reads #167

Buffer Socket Reads #167

Conversation

caleblloyd commented Jan 25, 2017

bgrainger Jan 25, 2017

Choose a reason for hiding this comment

bgrainger commented Jan 25, 2017