Check length of auth method switch payload for detecting old protocol. #316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Single 0xfe byte of the payload means it's an Old Authentication Method Switch Request Packet. See http://imysql.com/mysql-internal-manual/connection-phase-packets.html
kobake
force-pushed
the
check-authentication-method-switch-payload-length
branch
from
2e5f733
to
8263733
Compare
|
Thanks for the contribution! |
|
😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Single 0xfe byte of the payload means it's an Old Authentication Method Switch Request Packet.
See http://imysql.com/mysql-internal-manual/connection-phase-packets.html
When MySqlConnector of current master version received single 0xfe byte response from the server, it throws FormatException("Read past end of buffer looking for NUL.") that doesn't make sense.
This PR provides a message for suggesting to upgrade password hash format in MySQL user record.