New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check length of auth method switch payload for detecting old protocol. #316

Merged
merged 1 commit into from Aug 26, 2017

Conversation

Projects
None yet
2 participants
@kobake
Contributor

kobake commented Aug 26, 2017

Single 0xfe byte of the payload means it's an Old Authentication Method Switch Request Packet.
See http://imysql.com/mysql-internal-manual/connection-phase-packets.html

When MySqlConnector of current master version received single 0xfe byte response from the server, it throws FormatException("Read past end of buffer looking for NUL.") that doesn't make sense.

This PR provides a message for suggesting to upgrade password hash format in MySQL user record.

Check length of auth method switch payload for detecting old protocol.
Single 0xfe byte of the payload means it's an Old Authentication Method Switch Request Packet.
See http://imysql.com/mysql-internal-manual/connection-phase-packets.html
@bgrainger

This comment has been minimized.

Show comment
Hide comment
@bgrainger

bgrainger Aug 26, 2017

Member

Thanks for the contribution!

Member

bgrainger commented Aug 26, 2017

Thanks for the contribution!

@bgrainger bgrainger merged commit 5663b8c into mysql-net:master Aug 26, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@kobake

This comment has been minimized.

Show comment
Hide comment
@kobake

kobake Aug 26, 2017

Contributor

😄

Contributor

kobake commented Aug 26, 2017

😄

@kobake kobake deleted the kobake:check-authentication-method-switch-payload-length branch Aug 26, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment