Fix EF Core issue when using MySqlGeometry.Value #829
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EF Core throws an exception, when using
MySqlGeometry
, because there is some very general code inMicrosoft.EntityFrameworkCore.Storage.Internal.DbParameterCollectionExtensions.FormatParameterValue(StringBuilder builder, object parameterValue)
, that is unable to handle theReadOnlySpan<byte>
type ofMySqlGeometry.Value
.This PR changes the type to
byte[]
instead. Technically, this is a breaking change for anyone who used theValue
property before. But because of the implicit cast betweenbyte[]
andReadOnlySpan<byte>
, this should be less of an issue.In any case, if there is an issue in someones code, this change will lead to a compiler error, that can be easily fixed by replacing
Value
with eitherValue.AsSpan()
ornew ReadOnlySpan<byte>(Value)
.