Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Validator Data Model #58

Merged
merged 13 commits into from
Apr 9, 2020
Merged

New Validator Data Model #58

merged 13 commits into from
Apr 9, 2020

Conversation

live-wire
Copy link
Contributor

@live-wire live-wire commented Mar 5, 2020

  • This PR uses Validator's new Data Model.
    • Creates DataSource by using com.booking.validator.data.source
    • Creates data source Transformations using com.booking.validator.data.source.transformation
    • Creates Validation Task by using com.booking.validator.data.task
  • Contains Validation config change to make use of the new Data Model.

WIP

@codecov
Copy link

codecov bot commented Apr 8, 2020

Codecov Report

Merging #58 into master will decrease coverage by 0.27%.
The diff coverage is 51.72%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #58      +/-   ##
============================================
- Coverage     25.39%   25.11%   -0.28%     
  Complexity      276      276              
============================================
  Files           104      104              
  Lines          4332     4324       -8     
  Branches        414      414              
============================================
- Hits           1100     1086      -14     
- Misses         3137     3143       +6     
  Partials         95       95              
Impacted Files Coverage Δ Complexity Δ
...n/applier/hbase/writer/HBaseTimeMachineWriter.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
.../hbase/mutation/HBaseApplierMutationGenerator.java 66.48% <54.76%> (+0.21%) 12.00 <5.00> (ø)
...lication/applier/validation/ValidationService.java 86.84% <77.77%> (-3.49%) 14.00 <1.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80acd48...9c5779e. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented Apr 9, 2020

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 5 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@aka-netzero
Copy link
Contributor

Normally we wouldn't be willing to merge in this branch given that it disables all of the HBaseIntergrationTests that we have, but since the underlying Docker containers were broken by their maintainers we'll merge it in with an eye towards re-enabling the tests at a later date.

@live-wire live-wire merged commit 7c6e760 into master Apr 9, 2020
@live-wire
Copy link
Contributor Author

Follow up when this issue is resolved. 🤖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants