C extension - fix reference leaks when converting int/long/float (to mysql) #41
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the C extension (
use_pure = False
), query argument preparation results in reference leaks (viaMySQL_convert_to_mysql
) for the following argument types:int
andfloat
arguments, viaPyObject_Str
long
arguments (i.e. wheneverrepr()
thereof ends with an "L"), viaPyObject_Repr
(whennumeric
is not added to tuple)Note: There are additional shortcomings in said function which are not addressed by this patch: