mysqldumpslow: fix detection of slow log path #213
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without an argument mysqldumpslow tries to derive the path of the slow log from my_print_defaults, but that lists slow log like $ my_print_defaults mysqld ... --slow_query_log_file=/var/log/mysql/mysql-slow.log Fix the script to search with underscores instead of a hyphen. That way mysqldumpslow is most configurations will work without extra arguments. Fixes: https://bugs.launchpad.net/ubuntu/+source/mysql-5.7/+bug/819535 Signed-off-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>
|
Hi, thank you for submitting this pull request. In order to consider your code we need you to sign the Oracle Contribution Agreement (OCA). Please review the details and follow the instructions at http://www.oracle.com/technetwork/community/oca-486395.html |
|
Hi, there was no response to our request to sign an OCA or confirm the code is submitted under the terms of the OCA. As such this request will be closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without an argument mysqldumpslow tries to derive the path of the
slow log from my_print_defaults, but that lists slow log like
$ my_print_defaults mysqld
...
--slow_query_log_file=/var/log/mysql/mysql-slow.log
Fix the script to search with underscores instead of a hyphen.
That way mysqldumpslow is most configurations will work without extra
arguments.
Fixes: https://bugs.launchpad.net/ubuntu/+source/mysql-5.7/+bug/819535
Signed-off-by: Christian Ehrhardt christian.ehrhardt@canonical.com