Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libmysql: fix musl compatibility #385

Closed
wants to merge 1 commit into from

Conversation

stintel
Copy link

@stintel stintel commented Dec 31, 2021

The musl C library does not support res_ninit, res_nsearch and
res_nclose. Check if res_ninit is defined, and use res_search if not.

The musl C library does not support res_ninit, res_nsearch and
res_nclose. Check if res_ninit is defined, and use res_search if not.

Signed-off-by: Stijn Tintel <stijn@linux-ipv6.be>
@mysql-oca-bot
Copy link

Hi, thank you for submitting this pull request. In order to consider your code we need you to sign the Oracle Contribution Agreement (OCA). Please review the details and follow the instructions at https://oca.opensource.oracle.com/
Please make sure to include your MySQL bug system user (email) in the returned form.
Thanks

@stintel
Copy link
Author

stintel commented Jan 4, 2022

OCA approved and processed.

@mysql-oca-bot
Copy link

Hi, thank you for your contribution. Please confirm this code is submitted under the terms of the OCA (Oracle's Contribution Agreement) you have previously signed by cutting and pasting the following text as a comment:
"I confirm the code being submitted is offered under the terms of the OCA, and that I am authorized to contribute it."
Thanks

@stintel
Copy link
Author

stintel commented Jan 4, 2022

I confirm the code being submitted is offered under the terms of the OCA, and that I am authorized to contribute it.

@mysql-oca-bot
Copy link

Hi, thank you for your contribution. Your code has been assigned to an internal queue. Please follow
bug http://bugs.mysql.com/bug.php?id=106034 for updates.
Thanks

@stintel stintel deleted the libmysql-musl-compat branch January 5, 2022 13:56
thesamesam added a commit to thesamesam/mysql-server that referenced this pull request Nov 15, 2023
musl doesn't have res_n* functions so we are falling back to the not
thread safe ones.

Note that another approach was submitted at https://bugs.mysql.com/bug.php?id=106034
(mysql#385) but that is arguably less portable
given it takes the new path for everything non-glibc where things may already work
fine (e.g. Solaris).

This patch is less invasive.

Bug: https://bugs.gentoo.org/761352
See also: mysql#385
See also: https://bugs.mysql.com/bug.php?id=106034
parona-source pushed a commit to parona-source/mysql-server that referenced this pull request Jan 26, 2024
musl doesn't have res_n* functions so we are falling back to the not
thread safe ones.

Note that another approach was submitted at https://bugs.mysql.com/bug.php?id=106034
(mysql#385) but that is arguably less portable
given it takes the new path for everything non-glibc where things may already work
fine (e.g. Solaris).

This patch is less invasive.

Bug: https://bugs.gentoo.org/761352
See also: mysql#385
See also: https://bugs.mysql.com/bug.php?id=106034
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants