Fix hard-coded timestamps in main.derived_condition_pushdown MTR test #469
Conversation
Two hard-coded timestamps were added to this test in mysql@22f6ef90cae8#diff-d7e1b8c7138b94f92fbd555c44e7facc027cb50217f59f51729444ee7c3b37a4R1950 1. '2022-05-06 16:49:45' (assumed by the test's result file to be `< NOW()`) 2. '2023-05-06 16:49:45' (assumed by the test's result file to be `>= NOW()`) Because the second of these timestamps is now in the past, the test is now failing due to result mismatch. Tests should not be written to include hard-coded assumptions about the local time in their execution environment; these are essentially guaranteed to get out-of-date and cause failures. This test can very easily be rewritten to choose past/future timestamps relative to the time at which it is run, `DATE_ADD(NOW(), INTERVAL [+-] 1 DAY)`. Note that Ubuntu's build environment had to disable this test on 2022-05-09, likely due to encountering this problem: https://bugs.launchpad.net/ubuntu/+source/mysql-8.0/8.0.33-0ubuntu2 All new code of the whole pull request, including one or several files that are either new files or modified ones, are contributed under the BSD-new license. I am contributing on behalf of my employer Amazon Web Services, Inc.
|
Hi, thank you for submitting this pull request. In order to consider your code we need you to sign the Oracle Contribution Agreement (OCA). Please review the details and follow the instructions at https://oca.opensource.oracle.com/ |
|
I informed the Debian … and the Ubuntu packagers: https://bugs.launchpad.net/ubuntu/+source/mysql-8.0/+bug/2020696 |
|
Could any of the MySQL maintainers please give some initial feedback on this submission? Are you happy with this approach to fixing the test? Do you want me to continue with it? |
|
Hi @dlenski, Thanks for contributing to MySQL |
|
This contribution is under the OCA signed by Amazon and covering submissions to the MySQL project. |
|
Hi, there was no response to our request to sign an OCA or confirm the code is submitted under the terms of the OCA. As such this request will be closed. |
This is not correct. Why was this closed? The comment immediately above confirms that an OCA has been signed:
|
|
H @dlenski, |
|
Hi, thank you for your contribution. Please confirm this code is submitted under the terms of the OCA (Oracle's Contribution Agreement) you have previously signed by cutting and pasting the following text as a comment: |
|
Hi, thank you for your contribution. Your code has been assigned to an internal queue. Please follow |
|
Has this been merged yet? |
|
@athos-ribeiro, it appears not. Apparently an "alternative fix" was applied internal to Oracle/MySQL… but, as I quickly pointed out, that "fix" does not actually fix the problem. 🤦♂️ |
Two hard-coded timestamps were added to this test in 22f6ef90cae8#diff-d7e1b8c7138b94f92fbd555c44e7facc027cb50217f59f51729444ee7c3b37a4R1950
< NOW())>= NOW())Because the second of these timestamps is now in the past, the test is now failing due to result mismatch.
Tests should not be written to include hard-coded assumptions about the local time in their execution environment; these are essentially guaranteed to get out-of-date and cause failures.
This test can very easily be rewritten to choose past/future timestamps relative to the time at which it is run,
DATE_ADD(NOW(), INTERVAL [+-] 1 DAY).Note that Ubuntu's build environment had to disable this test on 2022-05-09, likely due to encountering this problem:
https://bugs.launchpad.net/ubuntu/+source/mysql-8.0/8.0.33-0ubuntu2