Destroy/end connections removed from the pool on error

fixes #1072
mysqljs · May 4, 2015 · 275473a · 275473a
1 parent 55f132c
commit 275473a
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/Changes.md b/Changes.md
@@ -6,6 +6,7 @@ you spot any mistakes.
 
 ## HEAD
 
+* Destroy/end connections removed from the pool on error
 * Delay implied connect until after `.query` argument validation
 * Do not remove connections with non-fatal errors from the pool
 * Error early if `callback` argument to `.query` is not a function #1060

diff --git a/lib/PoolConnection.js b/lib/PoolConnection.js
@@ -54,13 +54,13 @@ PoolConnection.prototype.destroy = function () {
   return Connection.prototype.destroy.apply(this, arguments);
 };
 
-PoolConnection.prototype._removeFromPool = function(connection) {
+PoolConnection.prototype._removeFromPool = function _removeFromPool() {
   if (!this._pool || this._pool._closed) {
     return;
   }
 
   var pool = this._pool;
   this._pool = null;
 
-  pool._removeConnection(this);
+  pool._purgeConnection(this);
 };