test(tests): Add more things to test in LOAD DATA INFILE tests #1438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding in more columns of varying types and tests to check validity of inserted data.
|
Thanks for the report. I have tracked this down to a regression in the packet writing with the new pool implementation. Will have this fixed in a jiffy! |
dougwilson
added a commit
that referenced
this pull request
Jun 8, 2016
|
@evansiroky, thanks again for reporting this! It is fixed in 2.11.1, which has been published to npm! |
|
Thanks for providing a fix so quickly! |
evansiroky
added a commit
to evansiroky/db-streamer
that referenced
this pull request
Jun 8, 2016
It was actually a bug with the node-mysql package which was fixed. See mysqljs/mysql#1438
|
it's no problem at all! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding in more columns of varying types and tests to check validity of inserted data.