Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: test iojs v1.2.0 on travis-ci #996

Merged
merged 1 commit into from Mar 18, 2015
Merged

build: test iojs v1.2.0 on travis-ci #996

merged 1 commit into from Mar 18, 2015

Conversation

sidorares
Copy link
Member

No description provided.

@dougwilson
Copy link
Member

Update package.json to match, please.

@sidorares
Copy link
Member Author

You mean "engines" field? I'm trying to understand what's current convention to indicate versions for both node and iojs. Heroku, for example, suggests using { "engines": { "iojs": "1.0.x" } }. Also all 1.0.x and 1.1.x versions wok just fine. Do we want to test them on travis? If not, should we indicate that they are not supported? ( we don't test against all node patch version anyway)

@dougwilson
Copy link
Member

Also all 1.0.x and 1.1.x versions wok just fine. Do we want to test them on travis?

Yes, if we want to support them.

we don't test against all node patch version anyway

correct, but we do test against all minor node.js versions we support and 1.0 and 1.1 and 1.2 are different minor versions (I'm not suggesting testing against all patch versions, though sometimes we probably should, but eh).

You mean "engines" field? I'm trying to understand what's current convention to indicate versions for both node and iojs. Heroku, for example, suggests using { "engines": { "iojs": "1.0.x" } }.

Yes, something. Right now, the engines.node will make npm display a warning to people if they install it on the wrong Node.js (or even just refuse to install if they set that option in their npm). I'm not sure what io.js/npm does.

@dougwilson
Copy link
Member

It's also important to note that I've seen written over and over again on io.js's site that they pledge that io.js is "backward-compatible" with Node.js, where in they say that as long as a library supports Node.js 0.12, then it should be able to automatically run on io.js. This library would fall under that promise, since we won't be using any non-Node.js 0.12 APIs (i.e. nothing io.js-only).

@sidorares
Copy link
Member Author

ok, I'll leave this open for now until I investigate behaviour of different npm versions re engines:node/iojs

Even with the promise of that io.js is "backward-compatible" it's good to have extra check that tests do actually run on iojs

@dougwilson
Copy link
Member

it's good to have extra check that tests do actually run on iojs

I agree, but it's hard to make a promise, at least in the current state (for example, as a Windows user io.js is basically useless because of node-gyp issues, etc.). We could certainly test on io.js and add it to the matrix to just allow it to fail, so we'd know if there is something to look into, but it won't force us to look into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants