Add firebase crashlytics to android app #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arrnas
commented
Oct 28, 2018
| @@ -23,12 +23,12 @@ buildscript { | |||
| allprojects { | |||
| repositories { | |||
| mavenLocal() | |||
| jcenter() | |||
There was a problem hiding this comment.
some random android dependency issue => facebook/react-native#21907 (comment)
Arrnas
force-pushed
the
feature/crashlytics_android
branch
from
89b1513
to
6b6e512
Compare
Arrnas
requested review from
donce,
ignasbernotas,
Waldz,
mipo47 and
shroomist
and removed request for
donce and
ignasbernotas
Waldz
approved these changes
Oct 29, 2018
| @@ -16,6 +16,9 @@ npm install -g react-native-cli | |||
|
|
|||
| ### Android | |||
|
|
|||
| * Crash reporting | |||
| * Download firebase crashlytics config - `google-services.json` from https://console.firebase.google.com and place it in `android/app/` | |||
There was a problem hiding this comment.
?? Should this be done for each developer individually? How will we track production errors?
shroomist
approved these changes
Oct 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#21