Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sometimes session timestamp is not being updated #1588

Closed
chompomonim opened this issue Jan 29, 2020 · 4 comments
Closed

Sometimes session timestamp is not being updated #1588

chompomonim opened this issue Jan 29, 2020 · 4 comments
Assignees
Labels
Projects

Comments

@chompomonim
Copy link
Contributor

Describe the bug
Many providers are seeing 1s sessions (usually from Netherlands) with big about of traffic:

Session ID                              Country              Duration        Traffic
31739a19-fdef-4087-8bc2-8ac84fa84afb	Netherlands		1s	     368.94 MB

Expected behavior
See proper duration in MMN dashboard and WebUI.

Screenshots
1s

Environment (please complete the following information):

  • Node version: 0.19.x
  • OS: raspbian, ubuntu
@chompomonim chompomonim added this to Icebox in Engineering via automation Jan 29, 2020
@zolia zolia moved this from Icebox to Todo in Engineering Jan 29, 2020
@ignasbernotas
Copy link
Contributor

ignasbernotas commented Jan 29, 2020

Testnet db:

Screenshot 2020-01-29 at 16 57 49

Session created_at and client_updated_at timestamps are identical. Looks like the consumer side isn't updating the session.

@chompomonim chompomonim changed the title Sometimes session timestamp not being updated Sometimes session timestamp is not being updated Jan 29, 2020
@zolia zolia self-assigned this Jan 30, 2020
@zolia zolia moved this from Todo to In progress in Engineering Jan 30, 2020
@zolia
Copy link
Contributor

zolia commented Jan 30, 2020

Analyzed this issue, looks like its a legit traffic with not so well description of duration. Traffic comes from monitoring agent and takes less than 1 min, to be generated. We send statistics once per 1 min first generated statistics entry has these number of MB of data already.

We will update mmn duration description to: "< 1 min"

@ignasbernotas , can you update this one?

@chompomonim
Copy link
Contributor Author

I have seen many sessions with duration of 3s or 10s. Is this problem related to monitoring agent only? Maybe he is closing connection is some other way than mobile app users?

@soffokl
Copy link
Member

soffokl commented Jan 31, 2020

On the session disconnect, we should send the final stats to make sure we have ended it gracefully.
https://github.com/mysteriumnetwork/node/blob/master/consumer/statistics/reporter.go#L102

On the other hand, there could be the case when the session stats could not be sent because of the non-gracefull end of the consumer process. But it should be a very rare case.

Engineering automation moved this from In progress to Done Feb 18, 2020
@chompomonim chompomonim moved this from Done to Archive in Engineering Feb 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Engineering
  
Archive
Development

No branches or pull requests

4 participants