Add tests for container routes #475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rossgray
force-pushed
the
add-tests-for-container-routes
branch
from
fdb855d
to
9468f49
Compare
rossgray
force-pushed
the
add-tests-for-container-routes
branch
from
4b8ea10
to
63d0a37
Compare
plutopulp
reviewed
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request outline
Add some tests for pipeline container routes, which are currently untested.
In order to get the tests working, I added a
lifespanevent for starting the execution handler loop: https://github.com/mystic-ai/pipeline/pull/475/files#diff-56467ebb52b06ad6784e7b2347f04e2947276d518f0b57f3f239ae45db46cbb3R46-R59(without this, the tests would hang as the coroutine never terminates, as it runs in an infinite loop).
I made the mistake of updating the version of Black we're using for autoformatting and it resulted in quite a few changes.
I also used this opportunity to remove the CLI commands related to environments, which are no longer used in V4 (these were also failing Black checks so thought it was best to remove them entirely).
I haven't
Checklist: