Added --stamp option, --stamp tests, and fixed two typos #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mysticatea
requested changes
Dec 23, 2016
| /coverage | ||
| /lib |
There was a problem hiding this comment.
Please revert this change.
The result of builds should not be included in git repo.
| @@ -223,4 +223,22 @@ NETWORK: | |||
| `); | |||
| })); | |||
| }); | |||
|
|
|||
| //-------------------------------------------------------------------------- | |||
| describe.only("--stamp option", () => { | |||
|
Done. |
|
Done
…______________________________________________________
Twitter: @virtualpatterns
Web: http://www.virtualpatterns.com
On Dec 22, 2016, at 11:49 PM, Toru Nagashima ***@***.***> wrote:
@mysticatea requested changes on this pull request.
Thank you for contributing.
This feature sounds reasonable to me.
Could you fix some things?
In .gitignore <#4 (review)>:
> /coverage
-/lib
Please revert this change.
The result of builds should not be included in git repo.
In test/generate.js <#4 (review)>:
> @@ -223,4 +223,22 @@ NETWORK:
`);
}));
});
+
+ //--------------------------------------------------------------------------
+ describe.only("--stamp option", () => {
Please remove .only.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#4 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAR4Hhcop-b3AwlnxCXke6UbqNr9Bs9Mks5rK1LPgaJpZM4LUXdj>.
|
|
Thank you! However, this PR still includes the result of builds ( |
|
Done … try again :-)
…______________________________________________________
Twitter: @virtualpatterns
Web: http://www.virtualpatterns.com
On Dec 23, 2016, at 6:46 PM, Toru Nagashima ***@***.***> wrote:
Thank you!
However, this PR still includes the result of builds (/lib and /bin). Could you remove those?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#4 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAR4HkUS2zGwyCNLQrTuSG538NzaDK3Hks5rLF1hgaJpZM4LUXdj>.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First time doing this ... be gentle :-)
Rationale is that sometimes, in development, I want to force an update even if nothing's changed in my app.