🐛 fix es/no-logical-assignment-operators autofix (fixes #57)

mysticatea · Dec 8, 2020 · 00d7385 · 00d7385
1 parent f48020f
commit 00d7385
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/lib/rules/no-logical-assignment-operators.js b/lib/rules/no-logical-assignment-operators.js
@@ -31,7 +31,7 @@ module.exports = {
                     node: operatorToken,
                     messageId: "forbidden",
                     fix(fixer) {
-                        if (utils.hasSideEffect(node.left, sourceCode)) {
+                        if (node.left.type !== "Identifier") {
                             return null
                         }
                         const newOperator = node.operator.slice(-1)

diff --git a/tests/lib/rules/no-logical-assignment-operators.js b/tests/lib/rules/no-logical-assignment-operators.js
@@ -40,7 +40,7 @@ new RuleTester().run("no-logical-assignment-operators", rule, {
         },
         {
             code: "a.b ||= c",
-            output: "a.b = a.b || (c)",
+            output: null,
             errors: ["ES2021 logical assignment operators are forbidden."],
         },
         {