Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CVE-2021-23362 in hosted-git-info #204

Open
kachkaev opened this issue Mar 25, 2021 · 8 comments
Open

CVE-2021-23362 in hosted-git-info #204

kachkaev opened this issue Mar 25, 2021 · 8 comments

Comments

@kachkaev
Copy link

We are using npm-run-all and are seeing this security alert since this morning: CVE-2021-23362. It is introduced via:

npm-run-all@4.1.5

read-pkg@3.0.0

normalize-package-data@2.5.0

hosted-git-info@2.8.8

Looks like upgrading read-pkg to ^5.2.0 should be enough to fix the issue. I’m happy to submit a PR if @mysticatea is happy to cut a release afterwards.

Meanwhile, we’ve added "hosted-git-info": "^4.0.2" to package.jsonresolutions.

@SymbioticKilla
Copy link

@mysticatea Hi, any plans to update it? Is this project alive?

@SymbioticKilla
Copy link

SymbioticKilla commented Mar 30, 2021

read-pkg@6.0.0 fixes the issue

@kachkaev
Copy link
Author

kachkaev commented Apr 2, 2021

read-pkg@6.0.0 could solve the problem indeed, but it would require this module to become ESM-only. See

Using read-pkg@5.2.0 still gives us a vulnerable version of hosted-git-info. If I upgrade read-pkg in this repo, then run npm ls hosted-git-info --prod, the result is:

└─┬ read-pkg@5.2.0
  └─┬ normalize-package-data@2.5.0
    └── hosted-git-info@2.8.8 

🤔

@mysticatea would you be interested in releasing a new breaking version of npm-run-all that would be ESM-only (i.e. for Node 12+)? If so, we can go for upgrading read-pkg to 6.0.0+ and refactoring some if the imports too.

@kachkaev
Copy link
Author

kachkaev commented Apr 2, 2021

An attempt to fix the issue is here: #205

I have some issues with AppVeyor and am giving up for now. Any help would be appreciated! @mysticatea 🙏

@dtothefp
Copy link

dtothefp commented May 3, 2021

Yes would be great to get this updated as we are having to move away from this package due to Snyk alerts

@kachkaev
Copy link
Author

kachkaev commented May 3, 2021

@dtothefp which alternative have you been able to find?

@lydell
Copy link

lydell commented May 6, 2021

We can also hope this is true: import-js/eslint-plugin-import#2046 (comment)

@lydell
Copy link

lydell commented May 9, 2021

Version 2.8.9 of hosted-git-info is now marked as unaffected by the vulnerability! I just got a PR from Dependabot silencing the alert.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants