Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace memory-streams package for memorystream #111 #112

Merged

Conversation

jlopezxs
Copy link
Contributor

Pull request to replace memorystreams package.
This replace is to fix bug #111 of superfluous memory.

@codecov-io
Copy link

codecov-io commented Oct 17, 2017

Codecov Report

Merging #112 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #112   +/-   ##
=======================================
  Coverage   91.86%   91.86%           
=======================================
  Files          22       22           
  Lines         455      455           
=======================================
  Hits          418      418           
  Misses         37       37
Impacted Files Coverage Δ
lib/run-tasks.js 85.07% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e83545...ca626b6. Read the comment docs.

@mysticatea
Copy link
Owner

I apology that I'm late to check this PR.
I will do within a few days.

Copy link
Owner

@mysticatea mysticatea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I'm sorry for delay.
I had misunderstood about this issue. It was not about memory usage. The memory-streams package seems to stop receiving after it has received some data due to backpressure.

@mysticatea mysticatea merged commit 096779b into mysticatea:master Nov 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants