Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for different nuget package name on PgServer constructor #23

Merged
merged 2 commits into from
Feb 23, 2023
Merged

support for different nuget package name on PgServer constructor #23

merged 2 commits into from
Feb 23, 2023

Conversation

mattiamerzi
Copy link
Contributor

@mattiamerzi mattiamerzi commented Feb 22, 2023

package PostgreSql.Binaries.Lite is a bit old; last nuget version is dated back to 4/9/2019, providing PostgreSQL version postgresql-10.7-1.

In order to give the user the possibility to use a different postgresql version or distribution, I've added an optional constructor parameter to the PgServer class that pushes a different nuget package name to the Downloader.

The default behaviour is obviously unchanged.

…m the default "PostgreSql.Binaries.Lite" has been added.
Copy link
Owner

@mysticmind mysticmind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, these are breaking changes. What other NuGet package are you planning to use to pull the Postgres version required?

src/MysticMind.PostgresEmbed/PgServer.cs Outdated Show resolved Hide resolved
@mysticmind mysticmind merged commit 893dd13 into mysticmind:master Feb 23, 2023
@mysticmind
Copy link
Owner

@mattiamerzi 2.1.0 is released, you can check the release notes here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants