Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After account migration, MyData can still access the old inactive user account #246

Open
jameswettenhall opened this issue Feb 18, 2020 · 0 comments

Comments

@jameswettenhall
Copy link
Contributor

See also: mytardis/mytardis#2301

MyTardis provides the ability to migrate an account (transfer ownership of data) from an old identity (with an outdated authentication mechanism) to a new identity (using OAuth2).

The MyTardis account migration renames the old account with a suffix indicating the old authentication mechanism, e.g. user1_ldap and the new OAuth account is expected to use an email address for the username, e.g. Full.Name@example.com. When MyData finds a user folder, e.g. a folder named using the email address, it tries to find the appropriate MyTardis user to grant access to, but currently the MyTardis API's /api/v1/user/ endpoint has no way to distinguish between active and inactive user accounts, so it appears possible that MyData could incorrectly grant access to the old (inactive) account instead of the new (migrated) account.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant