Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature : Tour Search View] #1000

Closed
FJBDev opened this issue Feb 22, 2023 · 4 comments
Closed

[Feature : Tour Search View] #1000

FJBDev opened this issue Feb 22, 2023 · 4 comments
Milestone

Comments

@FJBDev
Copy link
Collaborator

FJBDev commented Feb 22, 2023

What is missing ?

When using MT in Linux and trying to use the tour search feature, I see this message that requires the user to do the search in a separate browser instead of the embedded browser just like when using MT on windows:
image

Considering that this message was added back in February 2015 (8 years ago!), is this possible crash still a possibility ?? Or can the tour search be embedded when using Linux ?

@FJBDev FJBDev changed the title [Feature : Tour Seach View] [Feature : Tour Search View] Feb 22, 2023
@wolfgang-ch
Copy link
Collaborator

I tested the tour search with the embedded browser in my VM with Ubuntu 20.04 and it didn't crash. Can you also test it in your environment with this commit 5d21e6f

When it works on your PC then I will enable it in 23.3 but make it optional to disable it with a command line parameter

@FJBDev
Copy link
Collaborator Author

FJBDev commented Feb 26, 2023

Thanks, I will try on my Linux (Debian 11.6) and I will report if I experience any crash.

It's a good idea to make it enabled in 23.3 and then after several months, I will know if it crashes since I mostly use MT under Linux

@FJBDev
Copy link
Collaborator Author

FJBDev commented Feb 26, 2023

I tested and so far, I didn't experience any crashes 👍

image

wolfgang-ch added a commit that referenced this issue Feb 27, 2023
…wser is now also used in Linux.

The old behaviour can be enabled by setting the command line parameter "-DforceBrowserForTourSeachInLinux" when starting MyTourbook

#1000
@wolfgang-ch wolfgang-ch added this to the 23.3 milestone Feb 27, 2023
@FJBDev
Copy link
Collaborator Author

FJBDev commented May 21, 2023

I have been using the search view in MT on my Linux since 23.3 and have experienced 0 crashes so far 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants