Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature : Tour Editor] Scroll Wheel behaviour #1200

Closed
GurVJ opened this issue Oct 12, 2023 · 8 comments
Closed

[Feature : Tour Editor] Scroll Wheel behaviour #1200

GurVJ opened this issue Oct 12, 2023 · 8 comments
Milestone

Comments

@GurVJ
Copy link

GurVJ commented Oct 12, 2023

What is missing ?

In Tour Book Editor, using the scroll wheel allows to go down and up in the window but also to change selection in a combo box. So it often happens that while scrolling up and down the window, some data change by error (Tilte, Location, Time Zone, etc).
Would it be possible that the scrolling wheel in Combo Boxes could be activated only after having clicking on it once before ?

@FJBDev
Copy link
Collaborator

FJBDev commented Oct 12, 2023

I find it annoying too.
Here is my solution: Put the Tour Editor View in read-only mode so that you can scroll without modifying anything by accident

image

@GurVJ
Copy link
Author

GurVJ commented Oct 12, 2023

Yes it works but it is only a workaround (so not really user friendly).
Don't you think Combo boxes could be not "activated" by default ?

@FJBDev
Copy link
Collaborator

FJBDev commented Oct 12, 2023

Don't you think Combo boxes could be not "activated" by default ?

Maybe but that means we would also need to deactivate spinners etc....
Not sure what the best and most practical solution is

@stvzldn
Copy link

stvzldn commented Oct 13, 2023

I too find this to be somewhat non-standard. The Tour Editor is too "good" at sensing the mouse cursor position. Click outside of some boxes activates the box. Especially true in the Weather section.

@wolfgang-ch
Copy link
Collaborator

I'm currently implementing this feature but for the Air Quality field it is not easily possible to prevent the mouse wheel in the org.eclipse.nebula.widgets.tablecombo.TableCombo widget. There is no interface to hook into it to prevent the mouse wheel, the mouse wheel feature is builtin.

@wolfgang-ch
Copy link
Collaborator

This feature can be enabled/disabled in the tour editor options slideout

image

@wolfgang-ch wolfgang-ch added this to the 23.next milestone Oct 29, 2023
@wolfgang-ch wolfgang-ch changed the title [Feature : Tour Book Editor] Scroll Wheel behaviour [Feature : Tour Editor] Scroll Wheel behaviour Oct 29, 2023
@wolfgang-ch
Copy link
Collaborator

wolfgang-ch commented Oct 29, 2023

There is one imperfection, when the mouse is hovering a text field or a combo box and Scroll field content with the mouse wheel is disabled, the field content is not scroll (which is what was requested) but also the whole tour editor content is not scrolled

@wolfgang-ch
Copy link
Collaborator

Improved this feature, there are now two options when the field content should be scrolled

image

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants