Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Weather Log] Save log from the weather provider in the tour weather field #498

Closed
wolfgang-ch opened this issue Mar 30, 2022 · 7 comments
Closed
Assignees
Milestone

Comments

@wolfgang-ch
Copy link
Collaborator

It could be helpful when this weather log can be saved in the weather text field.
In the weather pref page this feature can be enabled/disabled.

image

image

@FJBDev
Copy link
Collaborator

FJBDev commented Mar 30, 2022

It's funny because I actually thought about the same thing several days ago but was wondering if users would like it.
I can do that in 22.next if you want

@wolfgang-ch
Copy link
Collaborator Author

I can do that in 22.next if you want

"Ich höre mich nicht nein sagen" -> "I can't hear myself saying no" (Yes)

https://www.google.com/search?client=firefox-b-d&q=ich+h%C3%B6re+mich+nicht+nein+sagen

@FJBDev FJBDev self-assigned this Mar 31, 2022
@FJBDev FJBDev added this to the 22.next milestone Mar 31, 2022
@FJBDev
Copy link
Collaborator

FJBDev commented Apr 6, 2022

Would it be useful to also save the name of the provider when the user has checked to save this weather log in the weather text field ?

@wolfgang-ch
Copy link
Collaborator Author

Would it be useful to also save the name of the provider when the user has checked to save this weather log in the weather text field ?

This should be optional, when you always have the same weather provider, you may not want it

@FJBDev
Copy link
Collaborator

FJBDev commented May 13, 2022

⚠️ WARNING ⚠️ :

For long tours, it's possible that the weather log exceeds what the weather description field can hold.
In this case, it will be truncated to meet the maximum 1000 characters allowed:

image

@wolfgang-ch
Copy link
Collaborator Author

For long tours, it's possible that the weather log exceeds what the weather description field can hold.
In this case, it will be truncated to meet the maximum 1000 characters allowed:

Why not increase the field size to 32'000 like with net.tourbook.data.TourData.DB_LENGTH_TOUR_DESCRIPTION_V10

@FJBDev
Copy link
Collaborator

FJBDev commented May 16, 2022

For long tours, it's possible that the weather log exceeds what the weather description field can hold.
In this case, it will be truncated to meet the maximum 1000 characters allowed:

Why not increase the field size to 32'000 like with net.tourbook.data.TourData.DB_LENGTH_TOUR_DESCRIPTION_V10

Yes, I can do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants