Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tour Chart] Show "Recorded Time" in value point tooltip #502

Closed
GurVJ opened this issue Apr 1, 2022 · 31 comments
Closed

[Tour Chart] Show "Recorded Time" in value point tooltip #502

GurVJ opened this issue Apr 1, 2022 · 31 comments
Milestone

Comments

@GurVJ
Copy link

GurVJ commented Apr 1, 2022

In the charts windows, the duration time indicated in the Info Tool Tip is the Elapsed time.
The feature request is that when the X-axis is selected to distance (km icon) then the duration time showed in the Info Tool Tip should be the recorded time (or at least the user should have the choice), so that there will be no longer "time jump" when a pause occured.

The same behaviour with the Map view Info Tool Tip would be also great.

ThanX !

@wolfgang-ch
Copy link
Collaborator

The feature request is that when the X-axis is selected to distance (km icon) ... that there will be no longer "time jump" when a pause occured.

I don't see time jumps when the x-axis is showing distances, they occure when the x-axis is displaying time

x-Axis: Distance

image

x-Axis: Time

image

@GurVJ
Copy link
Author

GurVJ commented Apr 2, 2022

I am talking about "Time Jumps" into the Info ToolTip window :
image

@wolfgang-ch wolfgang-ch changed the title Tour charts - Time on Info Tool Tip [Tour Chart] Time in value point tooltip Apr 2, 2022
@wolfgang-ch
Copy link
Collaborator

wolfgang-ch commented Apr 2, 2022

I am talking about "Time Jumps" into the Info ToolTip window :

Now I understood it, an image is easier to understand than thousand words

image

@wolfgang-ch
Copy link
Collaborator

wolfgang-ch commented Mar 25, 2023

A new "Moving time without breaks" value in the Value Point Tooltip will be available in the next version. This value removes all computed break times from the elapsed time.

image

image

@GurVJ
Copy link
Author

GurVJ commented Mar 31, 2023

Thank you @wolfgang-ch, but would it be also possible to have the choice of the "Recorded time" value ?

@wolfgang-ch
Copy link
Collaborator

wolfgang-ch commented Mar 31, 2023

Do I understand it correctly, that you want, that Recorded time should be displayed in any locations within MT, with or without break time which should be defined, e.g. in the pref pages?

Why not use just Moving time ?

@GurVJ
Copy link
Author

GurVJ commented Mar 31, 2023

You understand correctly.

For me the Moving Time is a useless indicator or at least a secondary one. Indeed, it happens frequently that I am not moving during my activity : it could be during recovery times, during time while I am looking for my way, during "refueling" times, etc. But these times are fully part of my activity (my effort) and if I do not want them to be part of my activity then I just stop the watch. That is why the recorded time is the most important indicator for me (and it is the default one used in all sport apps).

@wolfgang-ch
Copy link
Collaborator

How should "your time" be computed ?

What is missing in the statistic times ?

image

@wolfgang-ch wolfgang-ch reopened this Apr 1, 2023
@GurVJ
Copy link
Author

GurVJ commented Apr 1, 2023

Nothing is missing in the statistic times : "my time" is "Recorded time".
So i just would like to have this time displayed in the tool tip (and idealy to have it also as an x-axis to graphics).

Recorded time is : Elapsed time - Pause Time
Or it also may be defined as the sum of all time intervals of the recorded points between Start and Stop events.

@GurVJ
Copy link
Author

GurVJ commented Apr 1, 2023

I just found an article from Garmin developer website, which gives definitions of all times used. The graph at the bottom of the article is a good summary ("Timer duration" is our "Recorded time")

https://developer.garmin.com/fit/cookbook/durations/

@wolfgang-ch
Copy link
Collaborator

The above link is not working, fixed link https://developer.garmin.com/fit/cookbook/durations/

@wolfgang-ch
Copy link
Collaborator

So i just would like to have this time displayed in the tool tip

In which tooltip

In the value point tooltip I added the moving time but now you want the recorded time, I'm a bit confused

@GurVJ
Copy link
Author

GurVJ commented Apr 1, 2023

I am also confused because the initial request was to add the Recorded Time

The feature request is that when the X-axis is selected to distance (km icon) then the duration time showed in the Info Tool Tip should be the recorded time (or at least the user should have the choice)

Then you added the Moving Time. Fine, but it does not answer the initial request, that's all.

Using the Moving Time is not reliable because it is a computed time so it depends on user parameters and because of GPS precision (even when the device is not moving, the position changes).

Let's have a look a the following case, with specific Moving Time parameters :
image

image

I moved more than 100 meters but the Moving Time did not change.

The only way to have reliable datas is to use Recorded Time (in addition to Elapsed Time).
But I can understand that it is not so easy to get (I think there is a link with issue [#1009])

Am I clearer ? I really try ;-)

@GurVJ
Copy link
Author

GurVJ commented Apr 1, 2023

After studying the data points given in the Tour Editor, the computed "formula" to get the Recorded Time for each point could be :
Elapsed Time for the active point (Temps) - [sum of (Time interval value (||sec) when Pause (P) is True) for all points before the active one]

See the following example (no other Pause before point #826)
image

@wolfgang-ch
Copy link
Collaborator

Can you attach this tour ?

@GurVJ
Copy link
Author

GurVJ commented Apr 2, 2023

D41A0557.zip

@wolfgang-ch
Copy link
Collaborator

I've total different values for moving time and speed.

Is your speed value of about 23 km/h realistic when you are running?

image

image

@wolfgang-ch
Copy link
Collaborator

After studying the data points given in the Tour Editor, the computed "formula" to get the Recorded Time for each point could be :
Elapsed Time for the active point (Temps) - [sum of (Time interval value (||sec) when Pause (P) is True) for all points before the active one]

This is exactly the formula, how the recorded time is computed

_tourData.setTourDeviceTime_Recorded(_tourData.getTourDeviceTime_Elapsed() - _tourData.getTourDeviceTime_Paused());

@wolfgang-ch
Copy link
Collaborator

I'll add the recorded time value to the value point tooltip

@GurVJ
Copy link
Author

GurVJ commented Apr 3, 2023

I've total different values for moving time and speed.

Yes, no suprise because we haven't got the same parameters for moving time in this example (I chose extrem values to illustrate that Moving Value is not reliable).

Is your speed value of about 23 km/h realistic when you are running?

Of course not :-)
That's why in my opinion, the average value shouldn't be computed with Moving Time or at least the user should have the choice with Recorded Time. And honestly I thought it was already the case with this :
image

I'll add the recorded time value to the value point tooltip

Thank you !

@wolfgang-ch
Copy link
Collaborator

The first pause 0:06 is an auto pause which is summarized in the recorded time

image

@wolfgang-ch wolfgang-ch changed the title [Tour Chart] Time in value point tooltip [Tour Chart] Show "Recorded Time" in value point tooltip Apr 4, 2023
@GurVJ
Copy link
Author

GurVJ commented Apr 4, 2023

What is the difference between the 0:06 pause and the 0:21 pause ? In both cases the timer is stopped, isn't it ?

@wolfgang-ch
Copy link
Collaborator

What is the difference between the 0:06 pause and the 0:21 pause ? In both cases the timer is stopped, isn't it ?

0:06 is an auto pause which is triggered by the device, e.g. when you are not moving below a specific speed, e.g. 2 km/h
0:21 is manually triggered by the user, when you press the pause/resume button on the device

@GurVJ
Copy link
Author

GurVJ commented Apr 4, 2023

OK, that's what I thought. So why do you include the 0:06 auto pause into the recorded time ? The stop button triggered by the user or by the device should be considered as indentical : the timer is no more running so it is not Recorded Time.

@wolfgang-ch
Copy link
Collaborator

It's implemented like in the example you have linked above

Time Duration == Recorded Time which is counting the 2 seconds (0:30...0:32) of the Standing Still time, Moving Time is ignoring these 2 seconds

image

@GurVJ
Copy link
Author

GurVJ commented Apr 4, 2023

Tell me if I am wrong but in your example there is no "Standing Still" state (the altitude graph would be continuous). There are only 2 "timer paused" states (one auto pause and one user pause), so the Recorded Time should be equal to your Moving Time.

@GurVJ
Copy link
Author

GurVJ commented Apr 4, 2023

Tomorrow I will try to record a tour with all situations to illlustrate my words.

@wolfgang-ch
Copy link
Collaborator

Tell me if I am wrong but in your example there is no "Standing Still" state (the altitude graph would be continuous). There are only 2 "timer paused" states (one auto pause and one user pause), so the Recorded Time should be equal to your Moving Time.

I think that it is a symbolic graph and not the elevation (altitude) graph.

@wolfgang-ch
Copy link
Collaborator

From https://developer.garmin.com/fit/cookbook/durations/

"Timer duration accounts for pauses during the recording of the activity due to a manual or auto-pause of the timer, and is always less than or equal to the elapsed duration. Timer duration only accumulates while the device timer is running."

The question is if the MT Recorded Time respectively Garmin Timer Duration should contain auto-pauses from the device or not ?

@GurVJ
Copy link
Author

GurVJ commented Apr 5, 2023

The question is if the MT Recorded Time respectively Garmin Timer Duration should contain auto-pauses from the device or not ?

You're right and to me the sentence "Timer duration only accumulates while the device timer is running." means that manual and auto-pause should be considered the same way : not part of Recorded Time (Timer duration).

Tomorrow I will try to record a tour with all situations to illlustrate my words.
Sorry I won't be able to do so because I hurt myself during my trainning session yesterday evening.

@FJBDev
Copy link
Collaborator

FJBDev commented Apr 5, 2023

You're right and to me the sentence "Timer duration only accumulates while the device timer is running." means that manual and auto-pause should be considered the same way : not part of Recorded Time (Timer duration).

And this is exactly how I implemented the recorded time in MT 20.11.0. Whether the pause is automatically triggered or manually triggered, it is substracted from the elapsed time to compute the recorded time.

You can see my original pull request details and explanation here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants