Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MT 20.3 : Fixes and translation #173

Merged
merged 67 commits into from
Mar 7, 2020
Merged

MT 20.3 : Fixes and translation #173

merged 67 commits into from
Mar 7, 2020

Conversation

FJBDev
Copy link
Collaborator

@FJBDev FJBDev commented Feb 21, 2020 •
edited

  • French translation and mnemonics improvement 🇫🇷



  • Tour Marker View : Replaced pace difference by average pace (see commit 516fa21)



  • Warnings removal (see commits 3281a8c, 1ee1a92 & a662b18)

Example:
image

Source



  • Tour Marker View : Added the average slope (see commit 40200d0)

image

In 20.2, pace displayed in hh:mm format:
image

In 20.Next, now displaying pace in mm:ss format
image



  • Conconi View: Disabling the deflection scale if there is no HR and/or power data (otherwise if the users modified the scale it would create an NPE) (see commit 4748ab6)

java.lang.NullPointerException
	at net.tourbook.conconi.ConconiView.onSelectDeflection(ConconiView.java:866)
	at net.tourbook.conconi.ConconiView.access$4(ConconiView.java:862)
	at net.tourbook.conconi.ConconiView$6.widgetSelected(ConconiView.java:691)
  • Fixed a regression that appeared in 17.4.1 where the USGS layers disappeared in the 3D Map Layer menu (due to the fact that WorldWind had changed the internal name of those layers from "Topographic" to "Topo Scanned". See here)
    (see commit 8b6ff23)

20.2.0:
image

20.Next.0 :
image

telemaxx and others added 30 commits December 2, 2019 21:26
@telemaxx
Merge pull request #42 from wolfgang-ch/master
4794dc2 
master2master
@telemaxx
Merge pull request #44 from wolfgang-ch/master
d953a30 
master2master
@telemaxx
Merge pull request #45 from wolfgang-ch/master
e41fef5 
master2master
@wolfgang-ch
resaved (caused reformatting) without content changes
b69cdc3
@wolfgang-ch
align the wording
f800641
@wolfgang-ch
little bit more UI spacing, enable/disable value units
f812087
@wolfgang-ch
Changed from Save -> Update, this action do not save the tour, saving…
07dc115 
… must be done additionally
@wolfgang-ch
removed "import javax.annotation.Generated;" which caused gradle buil…
1820922 
…d error

[ERROR] C:\DAT\mytourbook-BUILD-autocreated\core\net.tourbook\src\net\tourbook\preferences\MapsforgeStyleParser.java:[10]
[ERROR]         import javax.annotation.Generated;
[ERROR]                ^^^^^^^^^^^^^^^^^^^^^^^^^^
[ERROR] The import javax.annotation.Generated cannot be resolved
@wolfgang-ch
replaced eclipse NL 4.12 with 4.14
76d0ef6
@wolfgang-ch
external version updated to fix build issues
c6ac381
@wolfgang-ch
prepare version 4.14
6995e5f
@wolfgang-ch
MT 20.2 readme
1c96dc0
@wolfgang-ch
19.10 dutch translation
73d2bd8
@FJBDev
TODO Average heart rate in Marker View & mnemonic improvement for Tour
7b5341c 
contextual menu
@FJBDev
French translation
0f50812
@FJBDev
Contextual menu mnemonics improvements
29c43e5
@wolfgang-ch
fixed different formatter behaviour: chained methods are not wrapped …
3384bc0 
…as it was in eclipse before 4.14

hopefully no other formatting settings are changed with eclipse 4.14 which I not yet discovered
@wolfgang-ch
MT 20.2 readme/cheat sheet
6010abd
@wolfgang-ch
removed absolute layout indent, replaced selection listener with sele…
9ce4b06 
…ction adapter
@FJBDev
Merge remote-tracking branch 'origin/20-x'
bb5b815
@FJBDev
Undo
328d017
@FJBDev
French Mnemonic improvement
2502847
@FJBDev
Added average heart rate column in the Tour Marker View
1c199c0
@FJBDev
Bugfix : Array index issue when computing elevation gain/loss
09be84c 
(regression inserted in my commit 6d3c869)
@wolfgang-ch
Some dialog adjustments
65a63b3 
- radio buttons for new/offset values do display text now, otherwise a focus indicator is not visible, alternative a dropdown box could be used
- simplified enable controls, now there is more overhead but easier to read without many sub functions
- fixed: negative values could not be entered -> required for relative values
- fixed: changed elevation values did not immediately display the update gradient values in the time slice viewer, even after saving the tour it was not displayed only after reselecting the tour
- fixed: replaced bpm/rpm labels with it's translated texts
@wolfgang-ch
Merge pull request #171 from FJBDev/master
73ffa89 
Last modifications for 20.2 : French Tour Contextual menu mnemonics improvements, Added average heart rate column in the Tour Marker View & Bugfix : Array index issue when computing elevation gain/loss (regression inserted in my commit 6d3c869)
@wolfgang-ch
readme update
1cb6b2b
@telemaxx
Merge pull request #46 from wolfgang-ch/master
a9e71bb 
master2master
@FJBDev
French mnemonics improvements
6fe91a3
@FJBDev
French typo
de69801
@FJBDev FJBDev changed the title 20 next 20.next : Fixes and translation Feb 25, 2020
@FJBDev FJBDev changed the title 20.next : Fixes and translation MT 20.next : Fixes and translation Feb 26, 2020
@wolfgang-ch
Copy link
Collaborator

I created the Common_PullRequests_Branch that new commiters have a target.

For me it would be easier when you put your PR's in "your" branch https://github.com/wolfgang-ch/mytourbook/tree/FJBDev

@FJBDev FJBDev changed the base branch from Common_PullRequests_Branch to FJBDev February 26, 2020 14:26
@FJBDev
Copy link
Collaborator Author

FJBDev commented Feb 26, 2020 •
edited

I created the Common_PullRequests_Branch that new commiters have a target.

For me it would be easier when you put your PR's in "your" branch https://github.com/wolfgang-ch/mytourbook/tree/FJBDev

@wolfgang-ch Changed the target branch to FJBDev

@wolfgang-ch wolfgang-ch merged commit a509e74 into mytourbook:FJBDev Mar 7, 2020
@FJBDev FJBDev deleted the 20-next branch March 8, 2020 15:14
@FJBDev FJBDev changed the title MT 20.next : Fixes and translation MT 20.3 : Fixes and translation Mar 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wolfgang-ch wolfgang-ch Awaiting requested review from wolfgang-ch

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@FJBDev @wolfgang-ch @telemaxx