Support for recorded and paused time

[FJBDev]

Changes per code review suggestions in previous PR

[wolfgang-ch]

@FJBDev Let me know when I should do a review.

[FJBDev]

@FJBDev Let me know when I should do a review.

You can do a review :-)

[wolfgang-ch]

The code formatting do not join lines, so there can be "line breaks".

In the beginning the join line feature was tuned on but there was an issue (which I can't remember) that I turned it off. Maybe in later Eclipse versions this can be setup more granularly as I also hate to join the lines manually.

This is not an issue to not merge it into main branch

[wolfgang-ch]

Since a while I'm using the state contant name also for the state key, this is easier to use by just copy/paste it :-)

[wolfgang-ch]

When using UI.EMPTY_STRING then it is better to use it from net.tourbook.common.UI because when using other net.tourbook.common.UI resources then the fully qualified name for UI will be used

[wolfgang-ch]

tourRecordingTime is also renamed in the table TourCompared, I think this was not intended as the database update method do not reflect this renaming. I've not tested it but I think, MT will fail when it is accessing this table.

[wolfgang-ch]

After 2.5h of code review, I need to rest my brain as I'm getting tired. This is the reason why I can't work 100% after my bicycle accident. I think what makes me tired are the many "context" switches during the review as there are so many different files to look at.

Here you can see my current review location, I started from top to bottom and collapse all which is reviewed

[wolfgang-ch]

tourRecordingTime is also renamed in the table TourCompared, I think this was not intended as the database update method do not reflect this renaming. I've not tested it but I think, MT will fail when it is accessing this table.

This is the corresponding error when expanding a year in the ref tour view

[wolfgang-ch]

The code review is now done with 1 major issue, I'll do a functional review when the code is OK

[FJBDev]

The code review is now done with 1 major issue, I'll do a functional review when the code is OK

OK, i will fix the major issue and the other code suggestions quickly.

[FJBDev]

Since a while I'm using the state contant name also for the state key, this is easier to use by just copy/paste it :-)

Fixed

[FJBDev]

The code formatting do not join lines, so there can be "line breaks".

In the beginning the join line feature was tuned on but there was an issue (which I can't remember) that I turned it off. Maybe in later Eclipse versions this can be setup more granularly as I also hate to join the lines manually.

This is not an issue to not merge it into main branch

Fixed

[FJBDev]

When using UI.EMPTY_STRING then it is better to use it from net.tourbook.common.UI because when using other net.tourbook.common.UI resources then the fully qualified name for UI will be used

Fixed

[FJBDev]

tourRecordingTime is also renamed in the table TourCompared, I think this was not intended as the database update method do not reflect this renaming. I've not tested it but I think, MT will fail when it is accessing this table.

This is the corresponding error when expanding a year in the ref tour view

I have

The code review is now done with 1 major issue, I'll do a functional review when the code is OK

Ok, I have a fixed this 1 major issue here.

[FJBDev]

tourRecordingTime is also renamed in the table TourCompared, I think this was not intended as the database update method do not reflect this renaming. I've not tested it but I think, MT will fail when it is accessing this table.

I have renamed the field in the database. I had forgotten to do so.

[FJBDev]

After 2.5h of code review, I need to rest my brain as I'm getting tired. This is the reason why I can't work 100% after my bicycle accident. I think what makes me tired are the many "context" switches during the review as there are so many different files to look at.

Here you can see my current review location, I started from top to bottom and collapse all which is reviewed

Indeed, lots of changes and work for this feature. I started several weeks ago now :-)