Fixed score calculation w.r.t bias values in predict()

myui · Oct 18, 2013 · f895269 · f895269
1 parent 06d6239
commit f895269
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 2 deletions.
diff --git a/src/main/hivemall/classifier/BinaryOnlineClassifierUDTF.java b/src/main/hivemall/classifier/BinaryOnlineClassifierUDTF.java
@@ -200,7 +200,7 @@ protected float predict(final List<?> features) {
         if(biasKey != null) {
             WeightValue biasWeight = weights.get(biasKey);
             if(biasWeight != null) {
-                score += biasWeight.getValue();
+                score += (biasWeight.getValue() + bias);
             }
         }
 

diff --git a/src/main/hivemall/regression/OnlineRegressionUDTF.java b/src/main/hivemall/regression/OnlineRegressionUDTF.java
@@ -204,7 +204,7 @@ protected float predict(final Collection<?> features) {
         if(biasKey != null) {
             FloatWritable biasWeight = weights.get(biasKey);
             if(biasWeight != null) {
-                score += biasWeight.get();
+                score += (biasWeight.get() * bias);
             }
         }
 

diff --git a/target/hivemall.jar b/target/hivemall.jar