feature: Use the time of pull_request last update instead for voting …

…clock
myyk · May 29, 2023 · 461ddb8 · 461ddb8
1 parent 118647d
commit 461ddb8
Show file tree

Hide file tree

Showing 5 changed files with 19 additions and 17 deletions.
diff --git a/dist/index.js b/dist/index.js
diff --git a/dist/index.js.map b/dist/index.js.map
diff --git a/src/comments.ts b/src/comments.ts
@@ -189,9 +189,3 @@ export async function closeVotingComment(
 export async function commentToId(commit: Promise<Comment>): Promise<number> {
   return (await commit).id
 }
-
-export async function commentToCreatedAt(
-  commit: Promise<Comment>
-): Promise<Date> {
-  return (await commit).createdAt
-}
diff --git a/src/main.ts b/src/main.ts
@@ -11,7 +11,6 @@ import {
 } from './reactions'
 import {
   closeVotingComment,
-  commentToCreatedAt,
   commentToId,
   createVotingCommentBody,
   findOrRecreateVotingComment,
@@ -72,10 +71,17 @@ async function startOrUpdateHelper(
     issueNumber
   )
 
+  // TODO: could consolidate this call as it's used elsewhere
+  const pullRequest = await octokit.rest.pulls.get({
+    owner,
+    repo,
+    pull_number: issueNumber
+  })
+
   const votesPromise = weightedVoteTotaling(
     reactionCountsPromise,
     votersPromise,
-    commentToCreatedAt(comment)
+    Promise.resolve(new Date(pullRequest.data.updated_at))
   )
   const errorMessage = await evaluateVote(votingConfigPromise, votesPromise)
 

diff --git a/src/reactions.ts b/src/reactions.ts
@@ -52,6 +52,7 @@ export async function readReactionsCounts(
     }
 
     // add the author since they cannot review their own PR in Github
+    // TODO: could consolidate this call as it's used elsewhere
     const pullRequest = await octokit.rest.pulls.get({
       owner,
       repo,