- COTP: added payload length validation (see github #127)

mz-automation · Mar 5, 2019 · 0b2d97c · 0b2d97c
1 parent 9959158
commit 0b2d97c
Showing 1 changed file with 7 additions and 0 deletions.
diff --git a/src/mms/iso_cotp/cotp.c b/src/mms/iso_cotp/cotp.c
@@ -571,6 +571,13 @@ parseDataTpdu(CotpConnection* self, uint8_t* buffer, uint8_t len)
 static bool
 addPayloadToBuffer(CotpConnection* self, uint8_t* buffer,  int payloadLength)
 {
+    if (payloadLength < 1) {
+        if (DEBUG_COTP)
+            printf("COTP: missing payload\n");
+
+        return false;
+    }
+
     if (DEBUG_COTP)
         printf("COTP: add to payload buffer (cur size: %i, len: %i)\n", self->payload->size, payloadLength);